Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace github.com/pborman/uuid with github.com/google/uuid #7173

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Replace github.com/pborman/uuid with github.com/google/uuid #7173

merged 2 commits into from
Jan 22, 2024

Conversation

Juneezee
Copy link
Contributor

@Juneezee Juneezee commented Jan 6, 2024

What type of PR is this:

/area refactoring

What does this PR do / why we need it:

github.com/pborman/uuid is no longer being actively maintained (last release was 2019). So we should just use the newer github.com/google/uuid.

image

Which issue(s) this PR fixes:

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the area/refactoring Issues or PRs related to code refactoring label Jan 6, 2024
Copy link

openshift-ci bot commented Jan 6, 2024

Hi @Juneezee. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. label Jan 6, 2024
Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit e4bb039
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/65ae3ae3f8765f0008d382eb

@openshift-ci openshift-ci bot requested review from kadel and rm3l January 6, 2024 15:22
`github.com/pborman/uuid` is no longer being actively maintained (last
release was 2019). So we should just use the newer
`github.com/google/uuid`.

Signed-off-by: Eng Zer Jun <[email protected]>
@rm3l
Copy link
Member

rm3l commented Jan 15, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Jan 15, 2024
Reference: #7173 (review)
Co-authored-by: Armel Soro <[email protected]>
Signed-off-by: Eng Zer Jun <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Juneezee Juneezee requested a review from rm3l January 22, 2024 09:54
@rm3l rm3l added this to the v3.16.0 🚀 milestone Jan 22, 2024
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Juneezee !

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 943490b into redhat-developer:main Jan 22, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants