Redis 8 compatibility improvements and test infrastructure updates #2893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bobymicroby
force-pushed
the
use-8-in-tests
branch
3 times, most recently
from
ab31e4a to
66a0d27
Compare
bobymicroby
commented
Feb 11, 2025
bobymicroby
force-pushed
the
use-8-in-tests
branch
8 times, most recently
from
8bfc0ae to
483e072
Compare
This switches our testing infrastructure from redis/redis-stack to redislabs/client-libs-test Docker image across all packages. This change also updates the default Docker version from 7.4.0-v1 to 8.0-M04-pre.
bobymicroby
force-pushed
the
use-8-in-tests
branch
from
6600a14 to
2cbfd02
Compare
- Add tests for Redis 8 search configuration settings - Deprecate Redis Search CONFIG commands in favor of standard CONFIG - Test read-only config restrictions for Redis 8
- Update GEOPOS tests to handle increased precision in Redis 8 (17 decimal places vs 14) - Add precision-aware coordinate comparison helper - Add comprehensive test suite for coordinate comparison function
- Update tests to expect empty array ([]) instead of null for SUGGET variants - Affects sugGet, sugGetWithPayloads, sugGetWithScores, and sugGetWithScoresWithPayloads
- Add indexes_all field introduced in Redis 8 to index definition test
bobymicroby
force-pushed
the
use-8-in-tests
branch
3 times, most recently
from
272498b to
0c27ce5
Compare
bobymicroby
changed the title
bobymicroby
changed the title
bobymicroby
force-pushed
the
use-8-in-tests
branch
from
0c27ce5 to
24f34b0
Compare
- BREAKING CHANGE: FT.PROFILE now returns raw response, letting users implement their own parsing
- Add `testWithClientIfVersionWithinRange` method to run tests for specific Redis versions - Refactor TestUtils to handle version comparisons more accurately - Update test utilities across Redis modules to run tests against multiple versions, and not against latest only
bobymicroby
force-pushed
the
use-8-in-tests
branch
from
24f34b0 to
cd214f5
Compare
bobymicroby
changed the title
htemelski
approved these changes
Feb 26, 2025
Comment on lines
+55
to
+61
| assert.ok( | ||
| Math.abs(Number(result[0].longitude) - Number(coordinates.longitude)) < Math.pow(10, -PRECISION), | ||
| `Longitude mismatch: ${result[0].longitude} vs ${coordinates.longitude}` | ||
| ); | ||
| assert.ok( | ||
| Math.abs(Number(result[0].latitude) - Number(coordinates.latitude)) < Math.pow(10, -PRECISION), | ||
| `Latitude mismatch: ${result[0].latitude} vs ${coordinates.latitude}` |
There was a problem hiding this comment.
Any reason not to use compareWithPrecision?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes:
redislabs/client-libs-testcontainerBreaking Changes:
Test Coverage:
testWithClientIfVersionWithinRangehelperThis change set prepares the codebase for full Redis 8 compatibility while maintaining support for earlier versions.