Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get command keys for subcommands #2170

Merged
merged 3 commits into from
May 8, 2022
Merged

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented May 8, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

fixes #2165

@dvora-h dvora-h added feature New feature redis-7 labels May 8, 2022
@dvora-h dvora-h requested a review from chayim May 8, 2022 11:24
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2022

Codecov Report

Merging #2170 (bda5864) into master (5c99e27) will decrease coverage by 0.08%.
The diff coverage is 10.34%.

@@            Coverage Diff             @@
##           master    #2170      +/-   ##
==========================================
- Coverage   91.98%   91.89%   -0.09%     
==========================================
  Files         105      105              
  Lines       25287    25313      +26     
==========================================
+ Hits        23260    23262       +2     
- Misses       2027     2051      +24     
Impacted Files Coverage Δ
redis/cluster.py 91.72% <ø> (ø)
tests/test_cluster.py 97.54% <ø> (+0.05%) ⬆️
redis/commands/parser.py 68.13% <4.34%> (-20.28%) ⬇️
redis/client.py 88.76% <25.00%> (-0.28%) ⬇️
tests/test_commands.py 90.04% <50.00%> (+<0.01%) ⬆️
redis/asyncio/client.py 91.98% <0.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c99e27...bda5864. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The method xgroup_create of the redis cluster client fails when running on redis version 7.0.0.
3 participants