Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asyncio Search crash, and versioning 4.3.1 #2175

Merged
merged 1 commit into from
May 9, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented May 9, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@dvora-h dvora-h added the bug Bug label May 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

Merging #2175 (69042b5) into master (c51435d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2175      +/-   ##
==========================================
+ Coverage   91.98%   92.00%   +0.01%     
==========================================
  Files         108      108              
  Lines       27392    27393       +1     
==========================================
+ Hits        25197    25202       +5     
+ Misses       2195     2191       -4     
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
redis/commands/search/__init__.py 89.47% <100.00%> (+0.18%) ⬆️
tests/test_cluster.py 97.14% <0.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c51435d...69042b5. Read the comment docs.

@dvora-h dvora-h requested a review from chayim May 9, 2022 11:42
@chayim chayim changed the title Fix asyncio import in Search Fix asyncio import in Search, and version 4.3.1 May 9, 2022
@chayim chayim changed the title Fix asyncio import in Search, and version 4.3.1 Fix asyncio Search crash, and versioning 4.3.1 May 9, 2022
@chayim chayim merged commit 42b937f into redis:master May 9, 2022
@dvora-h dvora-h deleted the search-import branch June 18, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants