Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python2-only __nonzero__ method from cluster.py #2313

Merged
merged 1 commit into from
Jul 31, 2022

Conversation

sobolevn
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

__nonzero__ is not used in python3. And since currenct setup.py specifies that >= 3.7 is required, there's no need for this method.

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2022

Codecov Report

Merging #2313 (3a85387) into master (c94821c) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2313      +/-   ##
==========================================
- Coverage   92.16%   92.16%   -0.01%     
==========================================
  Files         110      110              
  Lines       28642    28640       -2     
==========================================
- Hits        26399    26397       -2     
  Misses       2243     2243              
Impacted Files Coverage Δ
redis/cluster.py 90.47% <ø> (+0.10%) ⬆️
redis/asyncio/client.py 92.09% <0.00%> (-0.18%) ⬇️
tests/test_cluster.py 96.96% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c94821c...3a85387. Read the comment docs.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Jul 31, 2022
@dvora-h dvora-h merged commit 01cc2b2 into redis:master Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants