-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typing for client __init__ #3357
Conversation
@Vulwsztyn Tests are failing, cause of conditional OpenSSL dependency |
@vladvildanov thanks I'll make it unconditional |
@Vulwsztyn Thank you for your contribution! |
3771028
to
d6a4326
Compare
@vladvildanov I changed the typing to string literals so that it doesn't require imports and removed the conditional imports |
@vladvildanov Any insight as to why the tests are failing now? Should I do something? |
852adb5
to
c53e5e3
Compare
@vladvildanov I fixed the linting issues. Sorry it took so long.
|
c53e5e3
to
7644229
Compare
rebased unto master |
@Vulwsztyn OpenSSL is still an issue if you have a look in CI logs |
@vladvildanov Thanks for the ping. I don't get something here. In this line Line 870 in 7d73d74
import OpenSSL , but it is not a dependency of this project? Should it remain so?
|
f0339e7
to
4b76013
Compare
Removed the typing requiring openssl |
4b76013
to
5ac186a
Compare
5ac186a
to
31dbb85
Compare
Could you try running the tests please? |
336b259
to
f5e9163
Compare
I refixed lint |
I see that all checks are passing. Would it be possible to merge this? |
@Vulwsztyn waiting for checks after latest sync with master and good to go |
* typing for client __init__ * typing with string literals * retry_on_error more specific typing * retry typing * fix lint --------- Co-authored-by: Vladyslav Vildanov <[email protected]>
* Fixed flacky TokenManager test (#3468) * Fixed flacky TokenManager test * Fixed additional flacky test * Removed token count assertion * Skipped test on version 3.9 * Fix incorrect attribute reuse (#3456) add CacheEntry Co-authored-by: zhousheng06 <[email protected]> Co-authored-by: Vladyslav Vildanov <[email protected]> * Expand type for EncodedT (#3472) As of PEP 688, type checkers will no longer implicitly consider bytearray to be compatible with bytes * Moved self._lock initialisation to Pool constructor (#3473) * Moved self._lock initialisation to Pool constructor * Added test case * Codestyle fixes * Added correct annotations * DOC-4423: add TCEs for various command pages (#3476) Co-authored-by: Vladyslav Vildanov <[email protected]> * DOC-4345 added testable JSON search examples for home page (#3407) * DOC-4345 added testable JSON search examples for home page * DOC-4345 avoid possible non-deterministic results in tests * DOC-4345 close connection at end of example * DOC-4345 remove unnecessary blank lines * Adding unit text fixes to improve compatibility with MacOS. (#3486) * Adding unit text fixes to improve compatibility with MacOS. * Applying review comments * Unifying the exception msg validation pattern for both test_connection.py files --------- Co-authored-by: Vladyslav Vildanov <[email protected]> * Add return type to `close` functions (#3496) * Add types to ConnectionPool.from_url (#3495) Co-authored-by: Vladyslav Vildanov <[email protected]> * Add types to execute method of pipelines (#3494) Co-authored-by: Vladyslav Vildanov <[email protected]> * DOC-4796 fixed capped lists example (#3493) Co-authored-by: Vladyslav Vildanov <[email protected]> * typing for client __init__ (#3357) * typing for client __init__ * typing with string literals * retry_on_error more specific typing * retry typing * fix lint --------- Co-authored-by: Vladyslav Vildanov <[email protected]> * test: Updated CredentialProvider test infrastructure (#3502) * test: Updated CredentialProvider test infrastructure * Added linter exclusion * Updated dev dependency * Codestyle fixes * Updated async test infra * Added missing constant * Updated package version * Updated testing versions and docs * Updated server versions * Fixed test --------- Co-authored-by: zs-neo <[email protected]> Co-authored-by: zhousheng06 <[email protected]> Co-authored-by: Shantanu <[email protected]> Co-authored-by: David Dougherty <[email protected]> Co-authored-by: andy-stark-redis <[email protected]> Co-authored-by: petyaslavova <[email protected]> Co-authored-by: Patrick Arminio <[email protected]> Co-authored-by: Artur Mostowski <[email protected]>
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
I only added typings to
__init__
method ofclient:Redis
classI realise this exists: #3252
But there were some comments and it is dead since the end of May, while I hope this PR introduces so little change that it is instantly mergeable.