-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds option not to raise exception when leaving context manager after lock expiration #3531
base: master
Are you sure you want to change the base?
Conversation
Hi @julianolm, thank you for your contribution! Your change will be reviewed soon. |
Hi @julianolm, can you please check the reported errors from code linters? |
Co-authored-by: Aarni Koskela <[email protected]>
Hey @petyaslavova , updated!!! Thanks! |
@julianolm you can run the linters locally - there are instructions in the contributing guide. |
Oh, great. Sorry I missed it. |
Fixes: #3532
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
I was having trouble using async locks with the context manager because it was failing when exiting the context manager after timeout had expired (even if my code executed successfully).
I would really like not to raise a
LockNotOwnedError
in the exit of the context manager (if I try to release a lock and it was already "released" then great!).I understand just changing the behavior would be critical, so I added an option to just behave this way when desired instead.
Issue: #3532