Refactor query classes #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbs333
previously approved these changes
Aug 30, 2024
| from redisvl.query.filter import Tag | ||
| # Initialize the base query with the full query string constructed from the filter expression | ||
| query_string = self._build_query_string() | ||
| super().__init__(query_string) |
There was a problem hiding this comment.
we should maybe call out somewhere that we are extending the RedisQuery now which is why it is like this
rbs333
previously approved these changes
Aug 30, 2024
rbs333
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support more advanced query params/settings of the Redis query engine, we needed a more flexible and customizable way to build RedisVL queries.
This PR introduces a simple refactor to inherit all redis-py Query module capabilities for each query type.
Source: https://github.com/redis/redis-py/blob/master/redis/commands/search/query.py
Updated user guide is still in flight **