Upgrade to Pydantic V2 models #281
Merged
+406
−294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerhutcherson
force-pushed
the
feat/RAAE-607-pydantic-upgrade
branch
from
5089dd3 to
d02025d
Compare
|
Beast PR 🔥 |
tylerhutcherson
force-pushed
the
feat/RAAE-607-pydantic-upgrade
branch
from
d02025d to
744a515
Compare
abrookins
reviewed
Feb 14, 2025
| @@ -110,7 +110,7 @@ def __init__( | |||
| existing_index = SearchIndex.from_existing( | |||
| name, redis_client=self._index.client | |||
| ) | |||
| if existing_index.schema != self._index.schema: | |||
| if existing_index.schema.to_dict() != self._index.schema.to_dict(): | |||
There was a problem hiding this comment.
Glad this worked, this is what I was going to suggest!
tylerhutcherson
force-pushed
the
feat/RAAE-607-pydantic-upgrade
branch
from
b37ba34 to
3f10f1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
pydantic ^2.0.0models, validators, and techniques. The implementation here improves performance of model construction and validation. It also introduces best practices when possible related to validators and serialization. Because RedisVL was already on pydantic v2, this change should not impact any end users as we already required this version and had been relying on thev1shim.