improve callback validation for data fetching #4056
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
briefly:
is_callable
long:
The Class" Redux_WordPress_Data" in '\redux-framework\redux-core\inc\classes\class-redux-wordpress-data.php', which populate some fields, is not calling class methods/callable arrays when its type is set to 'callback' and the 'args' value is the callable array.
on '\redux-framework\redux-core\inc\classes\class-redux-wordpress-data.php' , on the
switch($type)
statement, line 473, we have:which conditions does not include callable arrays, like the ones mentioned in Example 2 in this php doc
I don't know if originally it shouldn't call methods/arrays as custom callbacks, but since it is common to use callbacks in this format, it can be useful to include this.