Implement Supabase OAuth Provider Scopes and Redirects #2207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
reviewed
Apr 3, 2021
Tobbe
reviewed
Apr 3, 2021
| return await client.auth.refreshSession() | ||
| await client.auth.getSessionFromUrl() | ||
|
|
||
| window.history.replaceState({}, document.title, window.location.pathname) |
There was a problem hiding this comment.
Are you not hitting bug #1892 with this code? If you are, I have a solution for that issue, just need to clean it up and get it out.
There was a problem hiding this comment.
It might be a similar issue - I'd have to look more into #1892 but that's for the Auth0 client and this code in the Supabase client.
getSessionFromUrl() is specific to the Supabase go-true client.
Tobbe
approved these changes
Apr 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1830 and #1959
This PR bumps to Supabase to the latest supabase-js and adds support for: