Export node-adapter’s fromNodeRequest and toNodeRequest from @react-router/dev/vite/cloudflare

[acusti]

there’s a great project called Superflare that describes itself as a “full-stack toolkit for Cloudflare Workers” and offers user auth, an ORM and DB migration management for D1, and a bunch of other useful things. it provides a package specifically for integrating with Remix, which exports a vite dev proxy plugin that is a drop-in replacement for the cloudflareDevProxy plugin provided by Remix/RR v7 to automatically handle sessions and auth and provide it to the app load context. that plugin uses the fromNodeRequest and toNodeRequest utils from the vite/node-adapter.ts file (imported here).

i am currently working on making Superflare compatible with React Router v7, but the node-adapter.ts file is not available in the published dist/ directory of @react-router/dev. this one-line change to the vite/cloudflare.ts file will enable importing everything we need for the cloudflare dev proxy plugin in @superflare/remix like so:

import {
  cloudflareDevProxy,
  fromNodeRequest,
  toNodeRequest,
} from "@react-router/dev/vite/cloudflare";

i hope this change is amenable to you all. regardless, thank you all for such a great project/community resource! the greatly improved types for route files from RR v7 are most excellent, and more generally, i’ve found working with Remix and now RR v7 truly a pleasure.

[changeset-bot]

🦋 Changeset detected

Latest commit: 685b947

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages

Name	Type
@react-router/dev	Major
@react-router/fs-routes	Major
@react-router/remix-routes-option-adapter	Major
create-react-router	Major
react-router	Major
react-router-dom	Major
@react-router/architect	Major
@react-router/cloudflare	Major
@react-router/express	Major
@react-router/node	Major
@react-router/serve	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[acusti]

since i opened this PR, i found out that @mjackson/node-fetch-server’s Low-Level APIs has createRequest, which works as a drop-in replacement for fromNodeRequest, and sendResponse, which works as a drop-in replacement for toNodeRequest. now i’m thinking the better change here would be to delete the packages/react-router-dev/vite/node-adapter.ts file entirely and just use @mjackson/node-fetch-server instead.

or we can just leave everything as is and i can close the PR. when i switched superflare over to using the @mjackson/node-fetch-server low-level APIs, i triggered remix-run/remix#10014, which meant i had to update the entry.server.tsx file to match the latest in the react-router-templates repo. i’m not sure if that means existing issues with broken AbortController implementations are revealed by the change and it’s therefore a good thing, or if it means that it’s better to just leave it as it is to avoid causing new errors for react-router users migrating from remix.