-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize ReadonlyMap and ReadonlySet types #13092
base: dev
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: bc4c0a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @bjohn465, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
This is me signing the Contributor License Agreement (CLA).
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
I made an attempt at fixing this issue by updating the I was not sure if I should update the |
ReadonlyMap
andReadonlySet
are regularMap
andSet
objects, but their types omit the mutation methods that theMap
andSet
types have, similar to the wayReadonlyArray
andArray
work. However,ReadonlyMap
andReadonlySet
do not extendMap
andSet
, so their types do not serialize correctly when coming from the server.This is related to the discussion in #13043