Merge branch 'main' into bug/TypeErrors-instead-of-not-found

remix-run · Apr 26, 2023 · 57fc1c7 · 57fc1c7
2 parents 1016dcd + 11f2d6b
commit 57fc1c7
Show file tree

Hide file tree

Showing 270 changed files with 12,495 additions and 5,449 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -18,6 +18,7 @@ module.exports = {
         "no-undef": OFF,
         "no-unused-expressions": OFF,
         "no-unused-vars": OFF,
+        "@typescript-eslint/no-redeclare": OFF,
       },
     },
     {

diff --git a/.github/workflows/deployments.yml b/.github/workflows/deployments.yml
@@ -28,15 +28,16 @@ on:
       TEST_VERCEL_USER_ID:
         required: true
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   arc_deploy:
     name: Architect Deploy
     if: github.repository == 'remix-run/remix'
     runs-on: ubuntu-latest
     steps:
-      - name: 🛑 Cancel Previous Runs
-        uses: styfle/[email protected]
-
       - name: ⬇️ Checkout repo
         uses: actions/checkout@v3
 
@@ -71,9 +72,6 @@ jobs:
     if: github.repository == 'remix-run/remix'
     runs-on: ubuntu-latest
     steps:
-      - name: 🛑 Cancel Previous Runs
-        uses: styfle/[email protected]
-
       - name: ⬇️ Checkout repo
         uses: actions/checkout@v3
 
@@ -109,9 +107,6 @@ jobs:
     if: github.repository == 'remix-run/remix'
     runs-on: ubuntu-latest
     steps:
-      - name: 🛑 Cancel Previous Runs
-        uses: styfle/[email protected]
-
       - name: ⬇️ Checkout repo
         uses: actions/checkout@v3
 
@@ -148,9 +143,6 @@ jobs:
     if: github.repository == 'remix-run/remix'
     runs-on: ubuntu-latest
     steps:
-      - name: 🛑 Cancel Previous Runs
-        uses: styfle/[email protected]
-
       - name: ⬇️ Checkout repo
         uses: actions/checkout@v3
 
@@ -190,9 +182,6 @@ jobs:
     if: github.repository == 'remix-run/remix'
     runs-on: ubuntu-latest
     steps:
-      - name: 🛑 Cancel Previous Runs
-        uses: styfle/[email protected]
-
       - name: ⬇️ Checkout repo
         uses: actions/checkout@v3
 
@@ -228,9 +217,6 @@ jobs:
     if: github.repository == 'remix-run/remix'
     runs-on: ubuntu-latest
     steps:
-      - name: 🛑 Cancel Previous Runs
-        uses: styfle/[email protected]
-
       - name: ⬇️ Checkout repo
         uses: actions/checkout@v3
 
@@ -263,9 +249,6 @@ jobs:
     if: github.repository == 'remix-run/remix'
     runs-on: ubuntu-latest
     steps:
-      - name: 🛑 Cancel Previous Runs
-        uses: styfle/[email protected]
-
       - name: ⬇️ Checkout repo
         uses: actions/checkout@v3
 

diff --git a/.github/workflows/format.yml b/.github/workflows/format.yml
@@ -6,15 +6,16 @@ on:
       - main
       - dev
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   format:
     if: github.repository == 'remix-run/remix'
     runs-on: ubuntu-latest
 
     steps:
-      - name: 🛑 Cancel Previous Runs
-        uses: styfle/[email protected]
-
       - name: ⬇️ Checkout repo
         uses: actions/checkout@v3
         with:

diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -7,14 +7,15 @@ on:
       - dev
   pull_request:
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   lint:
     name: ⬣ Lint
     runs-on: ubuntu-latest
     steps:
-      - name: 🛑 Cancel Previous Runs
-        uses: styfle/[email protected]
-
       - name: ⬇️ Checkout repo
         uses: actions/checkout@v3
 
@@ -24,14 +25,15 @@ jobs:
           node-version-file: ".nvmrc"
           cache: "yarn"
 
-      - name: 📥 Install deps
-        run: yarn --frozen-lockfile
-
-      - name: Disable Eslint GitHub Actions Annotations
+      - name: Disable GitHub Actions Annotations
         run: |
+          echo "::remove-matcher owner=tsc::"
           echo "::remove-matcher owner=eslint-compact::"
           echo "::remove-matcher owner=eslint-stylish::"
 
+      - name: 📥 Install deps
+        run: yarn --frozen-lockfile
+
       - name: 🔬 Lint
         run: yarn lint
 

diff --git a/.github/workflows/merged-pr.yml b/.github/workflows/merged-pr.yml
diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
@@ -5,6 +5,10 @@ on:
   schedule:
     - cron: "0 7 * * *" # every day at 12AM PST
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 env:
   CI: true
 
@@ -22,9 +26,6 @@ jobs:
       # allows this to be used in the `comment` job below - will be undefined if there's no release necessary
       NEXT_VERSION: ${{ steps.version.outputs.NEXT_VERSION }}
     steps:
-      - name: 🛑 Cancel Previous Runs
-        uses: styfle/[email protected]
-
       - name: ⬇️ Checkout repo
         uses: actions/checkout@v3
         with:
@@ -95,10 +96,6 @@ jobs:
     name: 📝 Comment on related issues and pull requests
     if: github.repository == 'remix-run/remix' && needs.nightly.outputs.NEXT_VERSION
     uses: ./.github/workflows/release-comments.yml
-    with:
-      ref: "refs/tags/v${{ needs.nightly.outputs.NEXT_VERSION }}"
-      package_version_to_follow: "remix"
-      release_branch: "dev"
 
   deployments:
     needs: [nightly]

diff --git a/.github/workflows/no-response.yml b/.github/workflows/no-response.yml
@@ -15,20 +15,27 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: 🥺 Handle Ghosting
-        uses: actions/stale@v7
+        uses: actions/stale@v8
         with:
-          days-before-close: 10
           close-issue-message: >
-            This issue has been automatically closed because we haven't received a
-            response from the original author 🙈. This automation helps keep the issue
-            tracker clean from issues that are unactionable. Please reach out if you
-            have more information for us! 🙂
+            This issue has been automatically closed because we didn't hear
+            anything from the original author after the previous notice.
           close-pr-message: >
-            This PR has been automatically closed because we haven't received a
-            response from the original author 🙈. This automation helps keep the issue
-            tracker clean from PRs that are unactionable. Please reach out if you
-            have more information for us! 🙂
-          # don't automatically mark issues/PRs as stale
-          days-before-stale: -1
+            This PR has been automatically closed because we didn't hear
+            anything from the original author after the previous notice.
           stale-issue-label: needs-response
+          stale-issue-message: >
+            This issue has been automatically marked stale because we haven't
+            received a response from the original author in a while 🙈. This
+            automation helps keep the issue tracker clean from issues that are
+            not actionable. Please reach out if you have more information for us
+            or you think this issue shouldn't be closed! 🙂 If you don't do so
+            within 7 days, this issue will be automatically closed.
           stale-pr-label: needs-response
+          stale-pr-message: >
+            This PR has been automatically marked stale because we haven't
+            received a response from the original author in a while 🙈. This
+            automation helps keep the issue tracker clean from issues that are
+            not actionable. Please reach out if you have more information for us
+            or you think this issue shouldn't be closed! 🙂 If you don't do so
+            within 7 days, this PR will be automatically closed.
diff --git a/.github/workflows/release-comments.yml b/.github/workflows/release-comments.yml
@@ -2,44 +2,20 @@ name: 📝 Comment on Release
 
 on:
   workflow_call:
-    inputs:
-      ref:
-        required: true
-        type: string
-      package_version_to_follow:
-        required: true
-        type: string
-      release_branch:
-        required: true
-        type: string
 
 jobs:
   comment:
-    name: Comment on Release
+    name: 📝 Comment on related issues and pull requests
     if: github.repository == 'remix-run/remix'
     runs-on: ubuntu-latest
     steps:
       - name: ⬇️ Checkout repo
         uses: actions/checkout@v3
-
-      - name: ⎔ Setup node
-        uses: actions/setup-node@v3
         with:
-          node-version-file: ".nvmrc"
-          cache: "npm"
-          cache-dependency-path: scripts/release/package-lock.json
-
-      - name: 📥 Install deps
-        run: npm ci
-        working-directory: ./scripts/release
+          fetch-depth: 0
 
-      - name: 📝 Comment on issues
-        working-directory: ./scripts/release
-        run: node -r esbuild-register ./comment.ts
-        env:
-          GITHUB_REPOSITORY: ${{ github.repository }}
-          GITHUB_TOKEN: ${{ github.token }}
-          VERSION: ${{ inputs.ref }}
-          DEFAULT_BRANCH: "main"
-          RELEASE_BRANCH: ${{ inputs.release_branch }}
-          PACKAGE_VERSION_TO_FOLLOW: ${{ inputs.package_version_to_follow }}
+      - name: 📝 Comment on related issues and pull requests
+        uses: mcansh/[email protected]
+        with:
+          DIRECTORY_TO_CHECK: "./packages"
+          PACKAGE_NAME: "remix"
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -9,6 +9,10 @@ on:
       - "!release-manual"
       - "!release-manual-*"
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   release:
     name: 🦋 Changesets Release
@@ -24,14 +28,10 @@ jobs:
       published_packages: ${{ steps.changesets.outputs.publishedPackages }}
       published: ${{ steps.changesets.outputs.published }}
     steps:
-      - name: 🛑 Cancel Previous Runs
-        uses: styfle/[email protected]
-
       - name: ⬇️ Checkout repo
         uses: actions/checkout@v3
         with:
           fetch-depth: 0
-          token: ${{ secrets.NIGHTLY_PAT }}
 
       - name: ⎔ Setup node
         uses: actions/setup-node@v3
@@ -62,7 +62,7 @@ jobs:
           publish: yarn run changeset:release
           createGithubReleases: false
         env:
-          GITHUB_TOKEN: ${{ secrets.NIGHTLY_PAT }}
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
 
   find_package_version:
@@ -73,9 +73,6 @@ jobs:
     outputs:
       package_version: ${{ steps.find_package_version.outputs.package_version }}
     steps:
-      - name: 🛑 Cancel Previous Runs
-        uses: styfle/[email protected]
-
       - name: ⬇️ Checkout repo
         uses: actions/checkout@v3
 
@@ -87,7 +84,7 @@ jobs:
 
       - id: find_package_version
         run: |
-          package_version=$(node ./scripts/release/find-release-from-changeset.js)
+          package_version=$(node ./scripts/find-release-from-changeset.js)
           echo "package_version=${package_version}" >> $GITHUB_OUTPUT
         env:
           PACKAGE_VERSION_TO_FOLLOW: "remix"
@@ -98,10 +95,6 @@ jobs:
     if: github.repository == 'remix-run/remix' && needs.find_package_version.outputs.package_version != ''
     needs: [release, find_package_version]
     uses: ./.github/workflows/release-comments.yml
-    with:
-      ref: refs/tags/remix@${{ needs.find_package_version.outputs.package_version }}
-      package_version_to_follow: "remix"
-      release_branch: ${{ github.ref_name }}
 
   deployments:
     name: 🚀 Deployment Tests