Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remix CLI reports false positives of missing "node_modules" when invoked from a different directory #5535

Closed
1 task done
TooTallNate opened this issue Feb 22, 2023 · 2 comments

Comments

@TooTallNate
Copy link
Contributor

What version of Remix are you using?

1.13.0

Are all your remix dependencies & dev-dependencies using the same version?

  • Yes

Steps to Reproduce

  1. cd to your Remix project
    cd ~/my-test
    
  2. Invoke Remix CLI located in a different project, or compiled from source located in this repository
    $ node ~/Code/remix-run/remix/packages/remix-dev/dist/cli.js build
    
  3. See false positive require.resolve() warnings for missing modules, even though those modules are indeed installed
    Building Remix app in production mode...
    The path "@remix-run/react" is imported in app/entry.server.tsx but "@remix-run/react" was not found in your node_modules. Did you forget to install it?
    The path "react-dom/server" is imported in app/entry.server.tsx but "react-dom/server" was not found in your node_modules. Did you forget to install it?</span>
    Built in 190ms
    

Expected Behavior

No require.resolve() warnings are printed, because the relevant packages do indeed exist within the project's node_modules directory.

Actual Behavior

False positive warning messages are printed, such as:

The path "react-dom/server" is imported in app/entry.server.tsx but "react-dom/server" was not found in your node_modules. Did you forget to install it?
@github-actions
Copy link
Contributor

This issue has been automatically marked stale because we haven't received a response from the original author in a while 🙈. This automation helps keep the issue tracker clean from issues that are not actionable. Please reach out if you have more information for us or you think this issue shouldn't be closed! 🙂 If you don't do so within 7 days, this issue will be automatically closed.

@github-actions github-actions bot added the needs-response We need a response from the original author about this issue/PR label Apr 23, 2023
@machour machour removed the needs-response We need a response from the original author about this issue/PR label Apr 29, 2023
@machour machour linked a pull request Apr 29, 2023 that will close this issue
2 tasks
@MichaelDeBoey
Copy link
Member

Fixed by #6181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants