fix(dev): Specify "paths" in require.resolve()
check
#6371
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
require.resolve()
by default will resolve module paths relative to the__filename
of the code that is invoking it. This normally works, by coincidence, because usually@remix-run/dev
is located within the project'snode_modules
directory.However, we get a false positive when
remix
CLI is located outside of the project directory, for example when testing changes in a local checkout of this repo.To fix, specify
paths
array torequire.resolve()
and explcitly specify thecwd
to resolve from.(Note: This is similar to #6181, but there appears to be duplicated code, and this file is missing the
paths
option).Before
(The modules are definitely installed, I promise)
After
Closes: #5535