Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle empty responses in single fetch requests #10410

Merged
merged 9 commits into from
Jan 21, 2025

Conversation

brophdawg11
Copy link
Contributor

Remix v2 version of remix-run/react-router#12760 to ease the upgrade path to v3_singleFetch -> RR v7

Closes #10328

Copy link

changeset-bot bot commented Jan 16, 2025

🦋 Changeset detected

Latest commit: 1e67d16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@remix-run/react Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/cloudflare Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/node Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/fs-routes Patch
@remix-run/route-config Patch
@remix-run/routes-option-adapter Patch
@remix-run/architect Patch
@remix-run/express Patch
@remix-run/serve Patch
create-remix Patch
remix Patch
@remix-run/css-bundle Patch
@remix-run/eslint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sergiodxa sergiodxa changed the title Properly handle empty responses in single fetch reqeusts Properly handle empty responses in single fetch requests Jan 17, 2025
@@ -10,7 +10,7 @@
"dependencies": {
"@cloudflare/kv-asset-handler": "^0.3.0",
"@cloudflare/workers-types": "^4.20230518.0",
"@playwright/test": "^1.33.0",
"@playwright/test": "^1.49.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed specifically to pick up changes in 1.37 that fix the running of tests on ubuntu

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to make a Chain Based crypto company that uses Felix Tokens as a new crypto currency called TX Use Felix Coins to either trade for other currency that are part of Chainlink or God of Chains or any other currency that are based on chaining your lost wallet to your new wallet if you loose it Patrica Tree aka Genies was full of lost wallets. I'm hoping chaining will prevent lost and stolen wallets I would be exclusive to Coinbase And Metamask and any other company willing to accept my crypto also buying Felix coins give you rewards by keeping it and stacking in return the host which would me Felix and anyone else that would like to buy Felix coins would get a big investment bc it would be like BNB but in chainlink way so everything but Felix tokens would be worth same trading value as fellow tokens Felix tokens would be for gas and collecting to make back value to be same worth as all the other currency around. Also every five min someone stealing my data or stealing my dev containers and reusing them I had locked and people where complaining that it was locked but there was point I'm trying to make I'm original person that was given Genies but I've had no luck keeping it. Everyone wants to be me or link themselves to my blockchain since of its worth sad people got steal to get ahead in life.

@brophdawg11 brophdawg11 merged commit 1afe78c into dev Jan 21, 2025
5 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/empty-response branch January 21, 2025 16:07
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jan 21, 2025
Copy link
Contributor

🤖 Hello there,

We just published version 2.15.3-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.15.3 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using data function with single_fetch enabled breaks when returning a status of 204
2 participants