docs(examples/google-analytics): Change to getting GA_TRACKING_ID via .env and update README #2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @chiangs, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
chiangs
changed the title
chiangs
changed the title
chaance
approved these changes
Apr 29, 2022
aaronpowell
pushed a commit
to aaronpowell/remix
that referenced
this pull request
May 10, 2022
… .env and update README (remix-run#2960) Co-authored-by: Stephen Chiang <[email protected]>
aaronpowell
pushed a commit
to aaronpowell/remix
that referenced
this pull request
May 12, 2022
… .env and update README (remix-run#2960) Co-authored-by: Stephen Chiang <[email protected]>
aaronpowell
pushed a commit
to aaronpowell/remix
that referenced
this pull request
May 15, 2022
… .env and update README (remix-run#2960) Co-authored-by: Stephen Chiang <[email protected]>
aaronpowell
pushed a commit
to aaronpowell/remix
that referenced
this pull request
May 16, 2022
… .env and update README (remix-run#2960) Co-authored-by: Stephen Chiang <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Google Analytics example. The example prior to this PR attempted to import the
GA_TRACKING_IDin the client util but the value won't be available when attempting to directly use it in the render.The example in this PR has the
GA_TRACKING_IDavailable in the process.env. Then the loader inroots.tsxprovides and returned via useLoaderData.