-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] getDependenciesToBundle
fails on package.json
with no main
field present
#3106
Conversation
3176eb0
to
6fbc297
Compare
getDependenciesToBundle
fails on package.json
with no main
field present
|
This particular scenario has been fixed in #7272. Note that the package must provide a |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Hi Remix Team,
thanks for this awesome library, I really enjoy using it in my side project.
I already opened this pull request a week ago and made a mistake in updating the branch.
So here it is again in its original form.
Please also look at #2594
I will write another pull request with the changes, I made locally as requested in the discussion.
Testing Strategy:
This test shows, that getDependenciesToBundle fails if the dependency has no
main
field in thepackage.json
Other bugs I would like to mention and provide tests and fixes for:
@types/*
packagesWhat would be the best way to provide tests for this?
Another pull request or separate test files inside this one?