Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] getDependenciesToBundle fails on package.json with no main field present #3106

Closed
wants to merge 3 commits into from

Conversation

Bushuo
Copy link

@Bushuo Bushuo commented May 5, 2022

Hi Remix Team,
thanks for this awesome library, I really enjoy using it in my side project.
I already opened this pull request a week ago and made a mistake in updating the branch.
So here it is again in its original form.

Please also look at #2594
I will write another pull request with the changes, I made locally as requested in the discussion.

  • Docs
  • Tests

Testing Strategy:
This test shows, that getDependenciesToBundle fails if the dependency has no main field in the package.json

Other bugs I would like to mention and provide tests and fixes for:

  • getDependenciesToBundle does not recurse and only outputs the input dependency
  • getDependenciesToBundle can not resolve @types/* packages

What would be the best way to provide tests for this?
Another pull request or separate test files inside this one?

@Bushuo Bushuo changed the base branch from main to dev May 6, 2022 00:29
@remix-run remix-run deleted a comment from ZipBrandon May 8, 2022
@MichaelDeBoey MichaelDeBoey force-pushed the getDependenciesToBundle-no-main branch from 3176eb0 to 6fbc297 Compare May 8, 2022 15:11
@MichaelDeBoey MichaelDeBoey changed the title Bug: getDependenciesToBundle fails on package.json with no "main" [bug] getDependenciesToBundle fails on package.json with no main field present May 8, 2022
@machour machour added the bug Something isn't working label May 21, 2022
@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2023

⚠️ No Changeset found

Latest commit: 76583ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markdalgleish
Copy link
Member

This particular scenario has been fixed in #7272. Note that the package must provide a "./package.json" export in order to resolve the path.

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-9154f35-20230829 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.0-pre.1 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-e3d5b17-20230916 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.1-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.1 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed package:dev
Projects
No open projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants