Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(tutorial/blog): Instruct to restart the dev server after marked install #3770

Merged
merged 3 commits into from
Jul 17, 2022
Merged

docs(tutorial/blog): Instruct to restart the dev server after marked install #3770

merged 3 commits into from
Jul 17, 2022

Conversation

Drew-Daniels
Copy link
Contributor

Closes: #3769

  • Docs

@Drew-Daniels
Added a note that explicitly tells users referencing these docs that …
bdd3731 
…they will need to restart their dev server after installing the marker dependency.
@changeset-bot
Copy link

changeset-bot bot commented Jul 16, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 76588c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 16, 2022

Hi @Drew-Daniels,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 16, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

dca123
dca123 suggested changes Jul 16, 2022
View reviewed changes
@machour machour changed the title Add a Note to That You Will Need to Restart Dev Server After Installing Marked Package on Quickstart Tutorial docs(tutorial/blog): Instruct to restart the dev server after marked install Jul 16, 2022
@machour machour added the docs label Jul 16, 2022
machour
machour approved these changes Jul 16, 2022
View reviewed changes
Copy link
Collaborator

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition since this is the first tutorial for Remix, and we want to be as clear as possible.

kentcdodds
kentcdodds approved these changes Jul 17, 2022
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@kentcdodds kentcdodds merged commit 3ed8b5d into remix-run:main Jul 17, 2022
dvargas92495 pushed a commit to dvargas92495/remix that referenced this pull request Jul 22, 2022
@Drew-Daniels @dvargas92495
docs(tutorial/blog): Instruct to restart the dev server after marked …
976d38a 
…install (remix-run#3770)

* Added a note that explicitly tells users referencing these docs that they will need to restart their dev server after installing the marker dependency.

* Added my name to accept CLA

* Moved instructions to line 585, after the marked instructions, and updated the language used after @dca123's suggestion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dca123 dca123 dca123 requested changes

@machour machour machour approved these changes

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees

@kentcdodds kentcdodds

Labels
CLA Signed docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instruct to restart the dev server after marked install in blog tutorial
4 participants
@Drew-Daniels @machour @kentcdodds @dca123