-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(guide): Clarify how to handle 404s #3798
Conversation
|
Hi @runmoore, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
fc301b4
to
69158ef
Compare
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
When discussing this topic with colleagues the wording 'you don't have to do anything' was interpreted in an ambiguous way. This re-phrasing linkis back to splat routes as a good option for handling 404s
69158ef
to
8d48e74
Compare
To dear reviewer: I really keen to know if it is intentional to have 2 kind of 404 handlings (spat route and catch boundary) being used together to catch simple route mismatch and response throws from loader/action function. Don't you believe they should be unified into one? Your response to this would be very helpful. |
@tat-ss There are actually 3 ways to handle 404 responses. Standard 404
if (responseStatusCode === 404) {
return new Response("Not Found", { status: 404 });
}
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this improved wording 👍
Co-authored-by: Chris Moore <[email protected]>
When discussing this topic with colleagues the wording 'you don't have to do anything' was interpreted in an ambiguous way.
This re-phrasing link's back to splat routes as a good option for handling 404s