-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(remix-dev): remove jsxDev
compiler option
#4358
Conversation
🦋 Changeset detectedLatest commit: 91aa5a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jsxDev
compiler option
it causes `import_jsx_dev_runtime.jsxDEV is not a function` errors when building prior to dev mode
249086b
to
0bfa1c8
Compare
Is this still planned @mcansh |
Is this still planned @mcansh? I'm facing still the same issue "import_jsx_dev_runtime.jsxDEV is not a function" on local when try to start with npm start, but when use "npm run dev" error not produced. |
@pcattori Is this still relevant in the new dev server? |
This error is caused when a Remix app is built in dev mode and subsequently started by an app server running in production: # 1. build app in dev mode
NODE_ENV=development remix build # either like this,
remix dev # or like this
# 2. later, without rebuilding for prod, run the app with a production-mode app server
NODE_ENV=production remix-serve # either like this,
NODE_ENV=production node ./server.js # or like this In CI/CD, your app should be getting built and run in production-mode only and shouldn't be a problem. For local dev, the solution is to infer the mode from the built Remix server, which is solved by #6964, making this PR obsolete. |
it causes
import_jsx_dev_runtime.jsxDEV is not a function
errors when building prior to dev modeCloses #4081
Closes #5743
Testing Strategy: