Code

feat: CSS side effect imports#4919

Code

Merged

markdalgleish merged 115 commits intodevremix-run/remix:devfrom markdalgleish/css-side-effectsremix-run/remix:markdalgleish/css-side-effectsCopy head branch name to clipboardJan 4, 2023

+835-46

Commits

Commits on Nov 24, 2022

• add initial CSS Modules integration

  markdalgleish

  committed
  8b9d1b8

  Copy full SHA for 8b9d1b8

• only write CSS bundle and source map to disk

  markdalgleish

  committed
  4cc9f8e

  Copy full SHA for 4cc9f8e

• Only emit CSS from the CSS bundle build

  markdalgleish

  committed
  5a55f96

  Copy full SHA for 5a55f96

• Merge branch 'dev' into markdalgleish/css-modules

  markdalgleish

  committed
  72de4a3

  Copy full SHA for 72de4a3

• bump css-bundle version

  markdalgleish

  committed
  fc57bae

  Copy full SHA for fc57bae

Commits on Nov 28, 2022

• clean up CSS build output logic

  markdalgleish

  committed
  5d96e1c

  Copy full SHA for 5d96e1c

• dispose CSS compiler in browser compiler

  markdalgleish

  committed
  48aaaf3

  Copy full SHA for 48aaaf3

• remove emitCss option, clean up server output

  markdalgleish

  committed
  9f40c89

  Copy full SHA for 9f40c89

• make CSS Modules object type readonly

  markdalgleish

  committed
  83eb997

  Copy full SHA for 83eb997

Commits on Nov 29, 2022

• add initial CSS Modules integration test

  markdalgleish

  committed
  0dcd2dc

  Copy full SHA for 0dcd2dc

• refactor local fork of CSS Modules plugin

  markdalgleish

  committed
  33b09aa

  Copy full SHA for 33b09aa

Commits on Dec 5, 2022

• bundle CSS to support composes property

  markdalgleish

  committed
  1352cc5

  Copy full SHA for 1352cc5

Commits on Dec 6, 2022

• put CSS Modules behind v2_cssBundle future flag

  markdalgleish

  committed
  ec7e32a

  Copy full SHA for ec7e32a

• Merge branch 'dev' into markdalgleish/css-modules

  markdalgleish

  committed
  6381250

  Copy full SHA for 6381250

• update css-bundle versions

  markdalgleish

  committed
  b4e2168

  Copy full SHA for b4e2168

• rename v2_cssBundle flag to unstable_cssBundle

  markdalgleish

  committed
  1599d3a

  Copy full SHA for 1599d3a

• remove CSS Module entry point cache

  markdalgleish

  committed
  88a0761

  Copy full SHA for 88a0761

• inline setup and buildCssModulesJs functions

  markdalgleish

  committed
  f31cd7a

  Copy full SHA for f31cd7a

• remove build context, clean up path resolution

  markdalgleish

  committed
  600897a

  Copy full SHA for 600897a

Commits on Dec 7, 2022

• use esbuild's resolver in lightningcss

  markdalgleish

  committed
  657ef3e

  Copy full SHA for 657ef3e

• refactor CSS Modules plugin

  markdalgleish

  committed
  55653e7

  Copy full SHA for 55653e7

• upgrade lightningcss

  markdalgleish

  committed
  08a6f66

  Copy full SHA for 08a6f66

• use relative path for filename

  markdalgleish

  committed
  d6d4d70

  Copy full SHA for d6d4d70

• add workaround for CSS Modules hash clashes

  markdalgleish

  committed
  ccf946f

  Copy full SHA for ccf946f

Commits on Dec 8, 2022

• simplify esbuild plugin, add PluginData type

  markdalgleish

  committed
  e63338d

  Copy full SHA for e63338d

• namespace compiled CSS suffix

  markdalgleish

  committed
  ea3e3bd

  Copy full SHA for ea3e3bd

• use complete path for virtual CSS file name

  markdalgleish

  committed
  be03658

  Copy full SHA for be03658

• split CSS Modules test cases, add more, clean up

  markdalgleish

  committed
  e2c2d1a

  Copy full SHA for e2c2d1a

• Merge branch 'dev' into markdalgleish/css-modules

  markdalgleish

  committed
  abdd5d3

  Copy full SHA for abdd5d3

• bump css-bundle versions

  markdalgleish

  committed
  1dc7da5

  Copy full SHA for 1dc7da5

• add unstable_cssBundle default to test package

  markdalgleish

  committed
  5254c2e

  Copy full SHA for 5254c2e

• ensure scoped grid line names don't break build

  markdalgleish

  committed
  3117fe4

  Copy full SHA for 3117fe4

• add CSS Modules to deterministic build test

  markdalgleish

  committed
  3e95c07

  Copy full SHA for 3e95c07

• ensure stable hashes when using import composition

  markdalgleish

  committed
  78f74bd

  Copy full SHA for 78f74bd

• add comment explaining pattern order

  markdalgleish

  committed
  57f688c

  Copy full SHA for 57f688c

• add comment about cwd limitation

  markdalgleish

  committed
  1e0c3a1

  Copy full SHA for 1e0c3a1

• Merge branch 'dev' into markdalgleish/css-modules

  markdalgleish

  committed
  41f65cf

  Copy full SHA for 41f65cf

Commits on Dec 9, 2022

• add test for root relative image URLs

  markdalgleish

  committed
  d17e6cd

  Copy full SHA for d17e6cd

Commits on Dec 11, 2022

• Merge branch 'dev' into markdalgleish/css-modules

  markdalgleish

  committed
  0641e8c

  Copy full SHA for 0641e8c

• fix esbuild resolve error after upgrade

  markdalgleish

  committed
  c8b8c33

  Copy full SHA for c8b8c33

• add CSS bundle deduplication test

  markdalgleish

  committed
  21c9e0b

  Copy full SHA for 21c9e0b

Commits on Dec 12, 2022

• clean up tests

  markdalgleish

  committed
  568adf2

  Copy full SHA for 568adf2

• rename test

  markdalgleish

  committed
  de3e1c3

  Copy full SHA for de3e1c3

• support import side effects in client entry

  markdalgleish

  committed
  039233b

  Copy full SHA for 039233b

• add trailing newline to tsconfig

  markdalgleish

  committed
  6ae02b2

  Copy full SHA for 6ae02b2

• update FutureConfig type, sort keys

  markdalgleish

  committed
  4a38a94

  Copy full SHA for 4a38a94

• add changeset

  markdalgleish

  committed
  2c5eb5a

  Copy full SHA for 2c5eb5a

• add initial docs

  markdalgleish

  committed
  be5b9cc

  Copy full SHA for be5b9cc

Commits on Dec 13, 2022

• migrate to postcss-modules, add tests and clean up

  markdalgleish

  committed
  61ac3c5

  Copy full SHA for 61ac3c5

• hoist postcss imports

  markdalgleish

  committed
  9709d24

  Copy full SHA for 9709d24

• format tsconfig

  markdalgleish

  committed
  385aed5

  Copy full SHA for 385aed5

• reorder imports

  markdalgleish

  committed
  a774503

  Copy full SHA for a774503

• reorder options

  markdalgleish

  committed
  66b0ad8

  Copy full SHA for 66b0ad8

• add root relative class composition to test

  markdalgleish

  committed
  77080dd

  Copy full SHA for 77080dd

• clean up css-bundle dist, add typings field

  markdalgleish

  committed
  beec55a

  Copy full SHA for beec55a

• Merge branch 'dev' into markdalgleish/css-modules

  markdalgleish

  committed
  778e4d2

  Copy full SHA for 778e4d2

• update note about CSS Modules support

  markdalgleish

  committed
  a698f16

  Copy full SHA for a698f16

• fix docs formatting

  markdalgleish

  committed
  ac9e013

  Copy full SHA for ac9e013

• update readme and description

  markdalgleish

  committed
  1bf956f

  Copy full SHA for 1bf956f

• update comment

  markdalgleish

  committed
  e06857c

  Copy full SHA for e06857c

• don't provide default object for entrypoints

  markdalgleish

  committed
  718909f

  Copy full SHA for 718909f

• remove redundant type annotations

  markdalgleish

  committed
  696e2c0

  Copy full SHA for 696e2c0

• remove redundant relative path

  markdalgleish

  committed
  d05e29f

  Copy full SHA for d05e29f

• simplify css compiler build step

  markdalgleish

  committed
  df3aa42

  Copy full SHA for df3aa42

• add comment explaining exports in css entry

  markdalgleish

  committed
  fffb86d

  Copy full SHA for fffb86d

• add comment explaining resolved module contents

  markdalgleish

  committed
  5baeff3

  Copy full SHA for 5baeff3

• simplify plugin data

  markdalgleish

  committed
  0243f83

  Copy full SHA for 0243f83

• use arrow functions for fixtures to reduce nesting

  markdalgleish

  committed
  3438678

  Copy full SHA for 3438678

• nit formatting

  markdalgleish

  committed
  8fc72b6

  Copy full SHA for 8fc72b6

• switch from patch to minor release

  markdalgleish

  committed
  a5a1e27

  Copy full SHA for a5a1e27

• convert unstable_cssBundle value to nested object

  markdalgleish

  committed
  806f033

  Copy full SHA for 806f033

• reinstate relative path to improve CSS comments

  markdalgleish

  committed
  61088c2

  Copy full SHA for 61088c2

• Merge branch 'dev' into markdalgleish/css-modules

  markdalgleish

  committed
  a3e95d1

  Copy full SHA for a3e95d1

• flatten CSS Modules feature flag

  markdalgleish

  committed
  6347b79

  Copy full SHA for 6347b79

• make virtual css paths relative to root dir

  markdalgleish

  committed
  84131d3

  Copy full SHA for 84131d3

Commits on Dec 14, 2022

• rename CSS entry module ID and plugin

  markdalgleish

  committed
  8257efc

  Copy full SHA for 8257efc

• convert cssBundleHref to named export

  markdalgleish

  committed
  b8f6d42

  Copy full SHA for b8f6d42

Commits on Dec 18, 2022

• WIP

  markdalgleish

  committed
  0797be5

  Copy full SHA for 0797be5

• Merge branch 'dev' into markdalgleish/css-modules

  markdalgleish

  committed
  7ed88e0

  Copy full SHA for 7ed88e0

• bump css-bundle versions

  markdalgleish

  committed
  2a5098e

  Copy full SHA for 2a5098e

• Merge branch 'markdalgleish/css-modules' into markdalgleish/css-side-effects

  markdalgleish

  committed
  b6893f3

  Copy full SHA for b6893f3

• update lock file

  markdalgleish

  committed
  1dbfaff

  Copy full SHA for 1dbfaff

Commits on Dec 19, 2022

• use Babel to transform imports, handle more cases

  markdalgleish

  committed
  50772f9

  Copy full SHA for 50772f9

• Merge branch 'dev' into markdalgleish/css-modules

  markdalgleish

  committed
  fa2d219

  Copy full SHA for fa2d219

Commits on Dec 20, 2022

• Merge branch 'markdalgleish/css-modules' into markdalgleish/css-side-effects

  markdalgleish

  committed
  d774052

  Copy full SHA for d774052

• Merge branch 'dev' into markdalgleish/css-modules

  markdalgleish

  committed
  19dc2b7

  Copy full SHA for 19dc2b7

• Merge branch 'markdalgleish/css-modules' into markdalgleish/css-side-effects

  markdalgleish

  committed
  fbc9941

  Copy full SHA for fbc9941

• add test cases for named and namespace imports

  markdalgleish

  committed
  d4d34d1

  Copy full SHA for d4d34d1

• Merge branch 'dev' into markdalgleish/css-modules

  markdalgleish

  committed
  141ff02

  Copy full SHA for 141ff02

• Merge branch 'markdalgleish/css-modules' into markdalgleish/css-side-effects

  markdalgleish

  committed
  2a0e54b

  Copy full SHA for 2a0e54b

• don't output CSS Modules in server/app build

  markdalgleish

  committed
  aece1ee

  Copy full SHA for aece1ee

• Merge branch 'markdalgleish/css-modules' into markdalgleish/css-side-effects

  markdalgleish

  committed
  afa7d11

  Copy full SHA for afa7d11

• fix isCssBuild

  markdalgleish

  committed
  d9d1ebe

  Copy full SHA for d9d1ebe

Commits on Dec 21, 2022

• handle images in CSS side effects

  markdalgleish

  committed
  5b2710c

  Copy full SHA for 5b2710c

• nest fixture files in separate directories

  markdalgleish

  committed
  c2a2c3c

  Copy full SHA for c2a2c3c

• clean up test CSS

  markdalgleish

  committed
  436d28a

  Copy full SHA for 436d28a

• Update docs/guides/migrating-react-router-app.md

  Show description for fd6d3ed
  

  markdalgleish

  and

  chaance

  authored
  fd6d3ed

  Copy full SHA for fd6d3ed

• Update docs/guides/styling.md

  Show description for 6a30fb5
  

  markdalgleish

  and

  chaance

  authored
  6a30fb5

  Copy full SHA for 6a30fb5

• Update docs/guides/styling.md

  Show description for cc96521
  

  markdalgleish

  and

  chaance

  authored
  cc96521

  Copy full SHA for cc96521

• Update docs/guides/styling.md

  Show description for 5cb0efb
  

  markdalgleish

  and

  chaance

  authored
  5cb0efb

  Copy full SHA for 5cb0efb

• Update packages/remix-dev/compiler/compileBrowser.ts

  Show description for cc5dc69
  

  markdalgleish

  and

  chaance

  authored
  cc5dc69

  Copy full SHA for cc5dc69

• Update packages/remix-dev/compiler/compileBrowser.ts

  Show description for 3ebae45
  

  markdalgleish

  and

  chaance

  authored
  3ebae45

  Copy full SHA for 3ebae45

• Update docs/guides/styling.md

  Show description for f0c7b82
  

  markdalgleish

  and

  chaance

  authored
  f0c7b82

  Copy full SHA for f0c7b82

• dedupe CSS in dev

  markdalgleish

  committed
  0da587d

  Copy full SHA for 0da587d

• remove explicit single CSS file warning from docs

  markdalgleish

  committed
  c7357fa

  Copy full SHA for c7357fa

• remove redundant optional chaining

  markdalgleish

  committed
  146ae5d

  Copy full SHA for 146ae5d

Commits on Dec 22, 2022

• Merge branch 'dev' into markdalgleish/css-modules

  markdalgleish

  committed
  ea9f2dc

  Copy full SHA for ea9f2dc

• Merge branch 'markdalgleish/css-modules' into markdalgleish/css-side-effects

  markdalgleish

  committed
  e230a36

  Copy full SHA for e230a36

• remove explicit single CSS file warning

  markdalgleish

  committed
  983cd2b

  Copy full SHA for 983cd2b

• update docs

  markdalgleish

  committed
  26836e8

  Copy full SHA for 26836e8

• use consistent casing

  markdalgleish

  committed
  9386ce9

  Copy full SHA for 9386ce9

• rename "side effects" to "side-effect imports"

  markdalgleish

  committed
  4e0023d

  Copy full SHA for 4e0023d

• clean up regular expression

  markdalgleish

  committed
  c8aa066

  Copy full SHA for c8aa066

Commits on Jan 4, 2023

• Merge branch 'dev' into markdalgleish/css-side-effects

  markdalgleish

  committed
  e8e5829

  Copy full SHA for e8e5829

• update docs

  markdalgleish

  committed
  a3abcbf

  Copy full SHA for a3abcbf