Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serve): update usage error to support ESM #7400

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Sep 13, 2023

Since remix-serve build doesn't work in ESM projects (it needs to be the file path, e.g. remix-serve build/index.js), I've updated all remix-serve usage docs to use the serverBuildPath format instead.

This notably includes a code change in remix-serve in one of its error messages which was incorrectly telling consumers to provide the server build directory rather than the server build path.

This also cleans up references in the docs to the now-removed serverBuildDirectory option since it was referenced in the remix-serve docs.

@markdalgleish markdalgleish added package:serve v2 Issues related to v2 apis labels Sep 13, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2023

🦋 Changeset detected

Latest commit: 0c71bf0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/serve Patch
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish merged commit 6430a57 into release-next Sep 13, 2023
@markdalgleish markdalgleish deleted the markdalgleish/remix-serve-esm-usage branch September 13, 2023 05:08
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.0-pre.11 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-3646f91-20230914 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed package:serve v2 Issues related to v2 apis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants