[#1817] Actions: update list of job runners environments for CI #1811
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,7 @@ jobs: | |
| name: ${{ matrix.os }} JDK 8 | ||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-18.04, ubuntu-20.04, ubuntu-22.04] | ||
| runs-on: ${{ matrix.os }} | ||
| env: | ||
| NODE_VERSION: "lts/*" | ||
|
|
@@ -106,7 +106,7 @@ jobs: | |
| name: ${{ matrix.os }} JDK 8 | ||
| strategy: | ||
| matrix: | ||
| os: [macos-11, macos-12] | ||
| runs-on: ${{ matrix.os }} | ||
| env: | ||
| HOMEBREW_NO_AUTO_UPDATE: 1 # Prevent time-consuming brew update | ||
|
|
@@ -173,7 +173,7 @@ jobs: | |
| name: ${{ matrix.os }} JDK 8 | ||
| strategy: | ||
| matrix: | ||
| os: [windows-2016, windows-2019, windows-2022] | ||
|
There was a problem hiding this comment. I'm not sure if we should add another Windows os for CI since this may impose additional load. Particularly because Windows CI is slower than that of Ubuntu. There was a problem hiding this comment. The jobs will run in parallel, so I think it does not cause the CI builds to take longer. Nonetheless, I removed it because I realized it was supposed to be deprecated by now. |
||
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - name: Checkout repository | ||
|
|
@@ -229,7 +229,7 @@ jobs: | |
|
|
||
| cypress: | ||
| name: Cypress frontend tests | ||
| runs-on: ubuntu-20.04 | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we should adopt
ubuntu-22.04since it's still in beta according to the actions/virtual-environments page.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, it is in beta currently. I added this such that we can run on this version, but I will not be marking the run as a required check (i.e. it is allowed to fail but will not block the PR from being merged).