-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2145] Dockerisation of RepoSense #2149
Conversation
Do note that the Docker containers currently do not conduct frontend tests using cypress, even though the dependencies are installed on the base Ubuntu containers, as they are consistently failing CI. Will look into the cause and update this thread once I have isolated the cause of the error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We just need to fix the Cypress issues.
FROM asdfghjklxd/reposense-images:ubuntu-22-04 AS setup-env | ||
|
||
LABEL os=ubuntu | ||
LABEL "os.version"="20.04" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be 22.04.
LABEL "os.version"="20.04" | |
LABEL "os.version"="22.04" |
- name: Build Docker Image | ||
run: | | ||
docker build -t ${{ matrix.tag }} -f ${{ matrix.dockerfile }} -o ${{ env.OUTDIR }} . | ||
# - name: Upload Code Coverage (Java 8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to be re-added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, since we're not using this for the CI, we can probably put this in a folder marked for local testing.
As mentioned in issue #2145, we are not pursuing this idea, hence I am closing out this PR. |
The following links are for previewing this pull request:
|
Part of #2145
Proposed commit message
Other information
This PR is part of the following steps outlined in the parent issue:
For this PR, only Ubuntu/Linux images are explored, as the rest are in development. Ubuntu/Linux images are also easier to work with and far less fussy compared to Windows and MacOS images, hence starting work on Ubuntu/Linux might be a helpful proof of concept for the viability of Docker for use for testing.