Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2292] Fix surge.sh preview failure on PR #2293

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[#2292] Fix surge.sh preview failure on PR #2293

wants to merge 10 commits into from

Conversation

CYX22222003
Copy link
Contributor

@CYX22222003 CYX22222003 commented Feb 13, 2025 •
edited
Loading

Fix #2292

Proposed commit message

Set allow_forks flag to true

The publish to surge.sh fails because of the failure in downloading
artifacts. This appears to be caused by the fact that default value
of allow_forks is false

Let's manually set allow_forks to true

Other information

@github-actions github-actions bot requested a deployment to dashboard-2293 February 13, 2025 00:03 Abandoned
@github-actions github-actions bot requested a deployment to docs-2293 February 13, 2025 00:03 Abandoned
@github-actions github-actions bot requested a deployment to dashboard-2293 February 13, 2025 00:22 Abandoned
@github-actions github-actions bot requested a deployment to docs-2293 February 13, 2025 00:22 Abandoned
@github-actions github-actions bot requested a deployment to dashboard-2293 February 13, 2025 00:31 Abandoned
@github-actions github-actions bot requested a deployment to docs-2293 February 13, 2025 00:31 Abandoned
@CYX22222003 CYX22222003 changed the title Update node version Explore surge.sh failures Feb 13, 2025
@github-actions github-actions bot requested a deployment to dashboard-2293 February 13, 2025 01:03 Abandoned
@github-actions github-actions bot requested a deployment to docs-2293 February 13, 2025 01:03 Abandoned
@github-actions github-actions bot requested a deployment to dashboard-2293 February 13, 2025 01:54 Abandoned
@github-actions github-actions bot requested a deployment to docs-2293 February 13, 2025 01:54 Abandoned
@CYX22222003 CYX22222003 mentioned this pull request Feb 13, 2025
Open
@github-actions github-actions bot requested a deployment to dashboard-2293 February 13, 2025 02:41 Abandoned
@github-actions github-actions bot requested a deployment to docs-2293 February 13, 2025 02:41 Abandoned
@github-actions github-actions bot requested a deployment to dashboard-2293 February 17, 2025 06:16 Abandoned
@github-actions github-actions bot requested a deployment to docs-2293 February 17, 2025 06:16 Abandoned
@CYX22222003 CYX22222003 marked this pull request as ready for review February 17, 2025 06:19
@CYX22222003 CYX22222003 changed the title Explore surge.sh failures [#2292] Fix surge.sh failures on PR Feb 17, 2025
@CYX22222003 CYX22222003 changed the title [#2292] Fix surge.sh failures on PR [#2292] Fix surge.sh preview failure on PR Feb 17, 2025
@CYX22222003 CYX22222003 requested review from sopa301 and a team February 17, 2025 06:20
@github-actions github-actions bot requested a deployment to dashboard-2293 February 17, 2025 07:49 Abandoned
@github-actions github-actions bot requested a deployment to docs-2293 February 17, 2025 07:49 Abandoned
sopa301
sopa301 approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot requested a deployment to dashboard-2293 February 20, 2025 07:46 Abandoned
@github-actions github-actions bot requested a deployment to docs-2293 February 20, 2025 07:46 Abandoned
@github-actions github-actions bot requested a deployment to dashboard-2293 February 22, 2025 23:44 Abandoned
@github-actions github-actions bot requested a deployment to docs-2293 February 22, 2025 23:44 Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sopa301 sopa301 sopa301 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
s.ToReview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Surge.sh Build Preview failing on recent PRs
2 participants
@CYX22222003 @sopa301