New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use base32 to format our TUIDs #9136

Open

emilk wants to merge 2 commits into main from emilk/base32-tuids

Member

emilk commented Feb 25, 2025 •

edited

Loading

Saves screenspace, e.g. when formatting dataframes

- 182342300C5F8C327a7b4a6e5a379ac4
+ 30HM4C0CBY634YKV99Q5MDWTRG

The old format still parses, so this is NOT a breaking change.

Related

Part of https://github.com/rerun-io/dataplatform/issues/250


          Use base32 to format our TUIDs

1042bc8

Saves space, e.g. when formatting dataframes

```diff
- 182342300C5F8C327a7b4a6e5a379ac4
+ 30HM4C0CBY634YKV99Q5MDWTRG
```

emilk added 🧑‍💻 dev experience exclude from changelog labels


          Actually use the base32 encoding when encoding chunk ids

cb1c79c

github-actions bot commented Feb 25, 2025 •

edited

Loading

Web viewer built successfully. If applicable, you should also test it:

I have tested the web viewer

Result	Commit	Link	Manifest
✅	`cb1c79c`	https://rerun.io/viewer/pr/9136	`+nightly` `+main`

^{Note: This comment is updated whenever you push a commit.}

Member

teh-cmc commented Feb 26, 2025 •

edited

Loading

My problem with this is that it's gonna make it very hard to match TUIDs dumped by Rerun-native stuff with TUID dumped by all other external tools and libraries (which will just use the vanilla FixedSizedBytes[16] representation, and are gonna become more and more common).

Member Author

emilk commented Feb 26, 2025

That's a good point 💡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧑‍💻 dev experience exclude from changelog