refactor: countElements returns NA if an element is invalid instead of dropping it #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR propose a solution to #64 .
I had to touch
.sum_elements
(change order of tests),calculateMass
(test forNULL
) andadductFormula
(drop invalid formulas silently) to keep the current behaviour (and pass all unit tests).Unfortunately we lose the position information (e.g. pos 3 contains "Fo").
BTW: I removed unnecessary
[
and]
in the regexp.