Unit test selectSpectraVariables fails if localData is present and requested

[meowcat]

selectSpectraVariables right now seems to be incompatible with using localData:

library(MsBackendMassbank)
library(RSQLite)
dbc <- dbConnect(SQLite(), system.file("sql", "minimassbank.sqlite",
                                       package = "MsBackendMassbank"))

# Works with no problems
be <- backendInitialize(MsBackendMassbankSql(), dbc)
res <- selectSpectraVariables(be, spectraVariables = spectraVariables(be))

## When adding localData: error
be@localData <- DataFrame(a = seq_along(be))
res <- selectSpectraVariables(be, spectraVariables = spectraVariables(be))

# Error in (function (cl, name, valueClass)  : 
#             assignment of an object of class “integer” is not valid for @‘localData’ in an object of class “MsBackendMassbankSql”; is(value, "DataFrame") is not TRUE

## When not requesting anything from localData, it works fine
res <- selectSpectraVariables(be, spectraVariables = setdiff(spectraVariables(be), "a"))

This is on 237dc75. Consequently, this causes the unit test to fail when using precursorMz caching (meowcat@7273224).

MsBackendMassbank/tests/testthat/test_MsBackendMassbankSql.R

Line 169 in 237dc75

test_that("selectSpectraVariables,MsBackendMassbankSql works", {

[jorainer]

Good catch! I will fix that.

[jorainer]

@meowcat could you please cross-check if the fix works for you too and eventually close the issue if so?

[meowcat]

Works. Thanks!