Back-compatible custom key manglers #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
==========================================
+ Coverage 99.91% 99.91% +<.01%
==========================================
Files 15 15
Lines 1179 1236 +57
==========================================
+ Hits 1178 1235 +57
Misses 1 1
Continue to review full report at Codecov.
|
and avoid excessive checking inside the mangler itself.
Details in the `storr_rds()` help file. Examples in the `register_mangler()` help file.
|
This morning, I added bug fixes, tests, and documentation. I think this PR is ready for an initial review. |
|
Just to let you know - this is absoutely on my radar, but this week has been busy. I will look at this asap |
|
Thanks, Rich. FYI I will be on vacation from Nov 15 to 27, so I do not expect this work to be fast. |
This was referenced Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, this PR is just a sketch of #89 (comment). It came together quicker than I predicted. @richfitz, if you agree with implementation, then I will write tests.