Add support for running scenarios with locally-defined services #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On second thought - we might just add current working directory of a running scipt (parent directory of omnetpp.ini) to ned folders. Libraries will be added globally (you cannot define targets with same names in CMake, anyway). This should also work. |
riebl
reviewed
Feb 19, 2025
|
Hey, @riebl! Apart from your suggestions I also added .flake8 formatting settings (considering we now have extensive amount of python code, some formatting seems reasonable). My only problem with this PR are install targets. Not all libraries & ned folders are getting installed, and with multi-config generators I cannot think of a way to generate options in uniform way. I would like to know your thoughts on this :) I removed installation of runner script and launch configs temporary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, @riebl!
I've realized that problem with libraries & ned folders originally was caused by the placement of script's generator function. If placed after processing scenarios, all dependencies are detected and formatted just fine. Although, I wonder if it is a good idea to put all services into one variable globally.
Special file with parameters for each scenario is a great alternative, but it seems like a significant overhead and might confuse people too much so they stop using this script completely.
What do you think?