Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless indent information from Buffer #4

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

GuillaumeGomez
Copy link
Contributor

First real PR for this project. :)

@GuillaumeGomez GuillaumeGomez requested a review from Kijewski June 17, 2024 16:45
@Kijewski
Copy link
Collaborator

Kijewski commented Jun 17, 2024

Good call! Maybe we can later add a prettyprint feature to indent the generated code using prettyplease, but I think that's very low on my TODO list.

With this change Buffer::writeln is infallible. Do you want to remove the Result type result?

@GuillaumeGomez
Copy link
Contributor Author

Good call, let's remove it. :)

@GuillaumeGomez
Copy link
Contributor Author

Done!

Copy link
Collaborator

@Kijewski Kijewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Much easier to read.

@GuillaumeGomez
Copy link
Contributor Author

I'll wait for you to merge this to ensure I correctly set up the team settings.

@Kijewski Kijewski merged commit 102a898 into rinja-rs:master Jun 18, 2024
16 checks passed
@Kijewski
Copy link
Collaborator

Thanks! I have a "merge" button now, but I don't have the privileges to add hooks.

@GuillaumeGomez GuillaumeGomez deleted the rm-indent-info branch June 18, 2024 09:47
@GuillaumeGomez
Copy link
Contributor Author

Let me fix that. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants