Remove a #[allow(clippy::match_wild_err_arm)] and dedup error message creation
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinja_derive/src/config.rs
Outdated
| Ok(source) | ||
| } else { | ||
| let msg = format!( | ||
| "unable to open template file '{}'", |
There was a problem hiding this comment.
I think we should provide the Err() value in the error message, it's not always obvious what's wrong (like wrong rights).
Kijewski
force-pushed
the
pr-one-less-allow
branch
from
6abf376 to
ddd4a81
Compare
| @@ -0,0 +1,10 @@ | |||
| error: unable to open template file '$WORKSPACE/target/tests/trybuild/rinja_testing/templates/a_file_that_is_actually_a_folder.html': | |||
| Is a directory (os error 21) | |||
There was a problem hiding this comment.
Hum... I think having the error text on the same line might be better. What do you think?
PS: Having a test for this is great, thanks!
There was a problem hiding this comment.
I wasn't sure if the line does not become too long, then. But chances are that you aren't using such a long path in a real project. :)
There was a problem hiding this comment.
Boarf, I think it's fine. I find it less confusing this way.
Kijewski
force-pushed
the
pr-one-less-allow
branch
from
ddd4a81 to
6a69946
Compare
GuillaumeGomez
approved these changes
Jul 4, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.