fix(iceberg): fix map - arrow convert & fix sink nested types to iceberg #18463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xxchan <[email protected]>
xxchan
changed the title
Signed-off-by: xxchan <[email protected]>
xxchan
force-pushed
the
xxchan/written-baboon
branch
from
2366134 to
6eef1cf
Compare
Signed-off-by: xxchan <[email protected]>
xxchan
force-pushed
the
xxchan/written-baboon
branch
from
7f5f492 to
d4b685a
Compare
Signed-off-by: xxchan <[email protected]>
xxchan
force-pushed
the
xxchan/written-baboon
branch
from
d4b685a to
76a232d
Compare
chenzl25
approved these changes
Sep 10, 2024
| // | ||
| // map: The standard name in arrow is "entries", "key", "value". | ||
| // in iceberg-rs, it's called "key_value" | ||
| (left, right) => left.equals_datatype(right), |
There was a problem hiding this comment.
Comparing only the datatype. That's exactly what we need!
Comment on lines
+16
to
+19
| v_decimal decimal(10,5), | ||
| v_map map<int, int>, | ||
| v_array array<int>, | ||
| v_struct struct<a:int, b:int> |
There was a problem hiding this comment.
Have you ever tried nesting a nested type inside another nested type?
There was a problem hiding this comment.
Just tried, and found a new icelake bug. It will fail to parse table metadata 🥵
chenzl25
changed the title
Signed-off-by: xxchan <[email protected]>
|
ping @risingwavelabs/cargo-lock |
BugenZhao
approved these changes
Sep 11, 2024
xxchan
added a commit
that referenced
this pull request
Sep 11, 2024
…erg (#18463) Signed-off-by: xxchan <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
…pes to iceberg (#18463) to branch release-2.0 (#18490) Signed-off-by: xxchan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.