Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix subscription clean during recovery #18866

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

yezizp2012
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title, this PR fixed a issue in simulation recovery test: https://buildkite.com/risingwavelabs/main-cron/builds/3488#01927729-79dd-40c8-a239-68a20b60e19f

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@yezizp2012 yezizp2012 added the need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged label Oct 11, 2024
@yezizp2012 yezizp2012 requested a review from xxhZs October 11, 2024 07:42
@yezizp2012 yezizp2012 requested a review from kwannoel October 11, 2024 07:42
@yezizp2012 yezizp2012 enabled auto-merge October 11, 2024 07:45
@yezizp2012 yezizp2012 added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit 755edb4 Oct 11, 2024
36 of 37 checks passed
@yezizp2012 yezizp2012 deleted the fix/subscription_clean branch October 11, 2024 08:40
github-merge-queue bot pushed a commit that referenced this pull request Oct 11, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-e2e-single-node-tests need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged need-cherry-pick-release-2.0 type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants