Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(risedev): support launching system rw in risedev-dev #18889

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Oct 14, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Support launching a cluster using risedev-dev with the risingwave binary installed in the PATH. To enable this, set USE_SYSTEM_RISINGWAVE or configure with ./risedev configure.

This can be useful if one wants to test the behavior of a released version of RisingWave, with the help of risedev-dev to launch some external services.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BugenZhao and the rest of your teammates on Graphite Graphite

@stdrc
Copy link
Member

stdrc commented Oct 14, 2024

Then what about RW_VERSION=1.9.0 ./risedev p to run a specific version?

@BugenZhao
Copy link
Member Author

BugenZhao commented Oct 14, 2024

Then what about RW_VERSION=1.9.0 ./risedev p to run a specific version?

Where can we get the binary for a specific version? 🥵 The current idea is to let users decide where to find the binary.

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good!

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stdrc
Copy link
Member

stdrc commented Oct 15, 2024

Then what about RW_VERSION=1.9.0 ./risedev p to run a specific version?

Where can we get the binary for a specific version? 🥵 The current idea is to let users decide where to find the binary.

Do we ship binary via homebrew or build from source?

@BugenZhao
Copy link
Member Author

Do we ship binary via homebrew or build from source?

We ship binary on Macs with Apple Silicon.

Copy link

gitguardian bot commented Oct 16, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9425213 Triggered Generic Password e6c7392 ci/scripts/e2e-source-test.sh View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@BugenZhao BugenZhao added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 9593210 Oct 16, 2024
29 of 31 checks passed
@BugenZhao BugenZhao deleted the bz/risedev-use-system-risingwave branch October 16, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants