Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump toolchain to nightly-2024-10-11 #19170

Merged
merged 11 commits into from
Oct 30, 2024

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Oct 29, 2024

Signed-off-by: MrCroxx [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Bump to 1.83.0 nightly version.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@MrCroxx MrCroxx requested a review from a team as a code owner October 29, 2024 08:28
@@ -21,6 +21,7 @@ use crate::aggregate::AggType;
use crate::Result;

/// Kind of window functions.
#[expect(clippy::large_enum_variant)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @stdrc for awareness, may fix in the future to improve performance.

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For dylint issues, I guess upgrading to 3.2.1 may help. Reference: trailofbits/dylint#1339

Signed-off-by: MrCroxx <[email protected]>
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@MrCroxx
Copy link
Contributor Author

MrCroxx commented Oct 30, 2024

Look GOOOOOOOOOOOOOOOD to me🤣

@MrCroxx MrCroxx enabled auto-merge October 30, 2024 13:00
@MrCroxx MrCroxx added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 8a8b368 Oct 30, 2024
31 of 32 checks passed
@MrCroxx MrCroxx deleted the xx/bump-toolchain-nightly-2024-10-11 branch October 30, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants