Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): fix corepack not enabled error #2058

Open
wants to merge 1 commit into
base: 02-20-fix_workflows_fix_activity_error_backoff_in_memory_polling
Choose a base branch
from

Conversation

NathanFlurry
Copy link
Member

Changes

Copy link
Member Author

NathanFlurry commented Feb 20, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Fixed Corepack enablement issue in Docker builds by reordering Node.js installation steps in the universal Dockerfile.

  • Modified docker/universal/Dockerfile to properly sequence NodeSource repository addition before Node.js installation and Corepack enablement
  • Ensures consistent package management functionality across Docker environments

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

cloudflare-workers-and-pages bot commented Feb 20, 2025

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: b2c46c3
Status: ✅  Deploy successful!
Preview URL: https://af589aeb.rivet-hub-7jb.pages.dev
Branch Preview URL: https://02-19-fix-docker-fix-corepac.rivet-hub-7jb.pages.dev

View logs

@MasterPtato MasterPtato force-pushed the 02-20-feat_workflows_implement_metrics_for_fdb_driver branch from 729d516 to c5b7bb3 Compare February 20, 2025 22:02
@MasterPtato MasterPtato force-pushed the 02-19-fix_docker_fix_corepack_not_enabled_error branch from 7f6cbbe to 22d17b8 Compare February 20, 2025 22:50
@MasterPtato MasterPtato changed the base branch from 02-20-feat_workflows_implement_metrics_for_fdb_driver to 02-20-fix_workflows_fix_activity_error_backoff_in_memory_polling February 20, 2025 22:50
Copy link

cloudflare-workers-and-pages bot commented Feb 20, 2025

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: b2c46c3
Status:🚫  Build failed.

View logs

@NathanFlurry NathanFlurry force-pushed the 02-19-fix_docker_fix_corepack_not_enabled_error branch from 22d17b8 to b2c46c3 Compare February 21, 2025 05:17
@MasterPtato MasterPtato force-pushed the 02-20-fix_workflows_fix_activity_error_backoff_in_memory_polling branch from 3b5b56c to 1ec5b9b Compare February 21, 2025 20:06
@MasterPtato MasterPtato force-pushed the 02-19-fix_docker_fix_corepack_not_enabled_error branch from b2c46c3 to 22d17b8 Compare February 21, 2025 20:07
@MasterPtato MasterPtato mentioned this pull request Feb 21, 2025
@NathanFlurry NathanFlurry force-pushed the 02-20-fix_workflows_fix_activity_error_backoff_in_memory_polling branch from 1ec5b9b to 3b5b56c Compare February 22, 2025 00:20
@NathanFlurry NathanFlurry force-pushed the 02-19-fix_docker_fix_corepack_not_enabled_error branch from 22d17b8 to b2c46c3 Compare February 22, 2025 00:20
@MasterPtato MasterPtato force-pushed the 02-20-fix_workflows_fix_activity_error_backoff_in_memory_polling branch from 3b5b56c to 1ec5b9b Compare February 22, 2025 02:54
@MasterPtato MasterPtato force-pushed the 02-19-fix_docker_fix_corepack_not_enabled_error branch from b2c46c3 to 22d17b8 Compare February 22, 2025 02:54
@NathanFlurry NathanFlurry force-pushed the 02-19-fix_docker_fix_corepack_not_enabled_error branch from 22d17b8 to b2c46c3 Compare February 22, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant