-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docker): fix corepack not enabled error #2058
Open
NathanFlurry
wants to merge
1
commit into
02-20-fix_workflows_fix_activity_error_backoff_in_memory_polling
Choose a base branch
from
02-19-fix_docker_fix_corepack_not_enabled_error
base: 02-20-fix_workflows_fix_activity_error_backoff_in_memory_polling
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(docker): fix corepack not enabled error #2058
NathanFlurry
wants to merge
1
commit into
02-20-fix_workflows_fix_activity_error_backoff_in_memory_polling
from
02-19-fix_docker_fix_corepack_not_enabled_error
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 20, 2025
This was referenced Feb 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Fixed Corepack enablement issue in Docker builds by reordering Node.js installation steps in the universal Dockerfile.
- Modified
docker/universal/Dockerfile
to properly sequence NodeSource repository addition before Node.js installation and Corepack enablement - Ensures consistent package management functionality across Docker environments
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Deploying rivet-hub with
|
Latest commit: |
b2c46c3
|
Status: | ✅ Deploy successful! |
Preview URL: | https://af589aeb.rivet-hub-7jb.pages.dev |
Branch Preview URL: | https://02-19-fix-docker-fix-corepac.rivet-hub-7jb.pages.dev |
729d516
to
c5b7bb3
Compare
7f6cbbe
to
22d17b8
Compare
22d17b8
to
b2c46c3
Compare
3b5b56c
to
1ec5b9b
Compare
b2c46c3
to
22d17b8
Compare
1ec5b9b
to
3b5b56c
Compare
22d17b8
to
b2c46c3
Compare
This was referenced Feb 22, 2025
Closed
3b5b56c
to
1ec5b9b
Compare
b2c46c3
to
22d17b8
Compare
22d17b8
to
b2c46c3
Compare
This was referenced Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes