WatchSketch is deadlock susceptible (uses fsnotify without separate goroutine) #68
Labels
bug
Something isn't working
Comments
robgonnella
added a commit
that referenced
this issue
Jul 11, 2021
Based on recommendations here: https://github.com/fsnotify/fsnotify#faq Issue #68
robgonnella
added a commit
that referenced
this issue
Jul 11, 2021
Based on recommendations here: https://github.com/fsnotify/fsnotify#faq Issue #68
robgonnella
added a commit
that referenced
this issue
Jul 11, 2021
Based on recommendations here: https://github.com/fsnotify/fsnotify#faq Issue #68
|
Nice find! Just pushed up changes to address this :) |
robgonnella
added a commit
that referenced
this issue
Jul 11, 2021
Based on recommendations here: https://github.com/fsnotify/fsnotify#faq Issue #68
|
Updated in new beta version, you can try it out via |
|
Hard to verify but the fix certainly looks good 🙂 |
|
Closing: Addressed in v2.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to howeyc/fsnotify#7, fsnotify/fsnotify#55 and https://github.com/fsnotify/fsnotify#faq, callers need to start a separate goroutine to select on watcher events (vs where
fsnotify.NewWatcher()is called). However, currentlyWatchSketch()is selecting events in the same thread where the watcher is created, which (apparently) may deadlock.Disclaimer: I am not very go-literate, so, could easily be misunderstanding things somehow.
The text was updated successfully, but these errors were encountered: