Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #include<chrono> in YarpDataplayer.h #3187

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Conversation

Nicogene
Copy link
Member

This PR adds #include in YarpDataplayer.h, this is causing a failure in icub-main CI:

This PR adds #include<chrono> in YarpDataplayer.h, this is causing a failure in icub-main CI:
- https://github.com/robotology/icub-main/actions/runs/13562094725/job/37908730516
@Nicogene Nicogene added Component: GUI - yarpdataplayer Affects: YARP v3.11.1 This is a known issue affecting YARP v3.11.1 labels Feb 27, 2025
@Nicogene Nicogene self-assigned this Feb 27, 2025
Copy link

update-docs bot commented Feb 27, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

@Nicogene
Copy link
Member Author

cc @pattacini

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Nicogene!

Copy link

codacy-production bot commented Feb 27, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+36.44%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b7a7cde) 427176 80406 18.82%
Head commit (0f78996) 112771 (-314405) 62315 (-18091) 55.26% (+36.44%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3187) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@Nicogene
Copy link
Member Author

Let's see if it is resolutive:

@Nicogene
Copy link
Member Author

image

@randaz81 randaz81 merged commit 0facb60 into yarp-3.11 Feb 27, 2025
136 of 147 checks passed
@randaz81 randaz81 deleted the Nicogene-patch-1 branch February 27, 2025 14:01
@traversaro
Copy link
Member

xref: microsoft/STL#5105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: YARP v3.11.1 This is a known issue affecting YARP v3.11.1 Component: GUI - yarpdataplayer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants