[esutil.Client] Allow for passing routing values to Get, Delete, and MultiGet #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #85 +/- ##
==========================================
+ Coverage 84.28% 84.42% +0.14%
==========================================
Files 9 9
Lines 999 1008 +9
==========================================
+ Hits 842 851 +9
Misses 93 93
Partials 64 64
Continue to review full report at Codecov.
|
mrparkers
reviewed
May 28, 2021
| } | ||
|
|
||
| type MultiGetRequest struct { | ||
| Index string | ||
| DocumentIds []string | ||
| Items []*EsMultiGetItem |
There was a problem hiding this comment.
what happens if both Items and DocumentIds are specified? is that okay to do, or should we guard against it?
There was a problem hiding this comment.
Seems fine. Couldn't find anything in the docs about it, but it looks like the behavior is to merge the results, in the order that the fields appear in the JSON
mrparkers
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for rode/rode#87