Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin Dark Theme #241

Closed
Sleitnick opened this issue Aug 29, 2019 · 1 comment
Closed

Plugin Dark Theme #241

Sleitnick opened this issue Aug 29, 2019 · 1 comment
Labels
scope: plugin Relevant to the Roblox Studio plugin type: enhancement Feature or improvement that should potentially happen

Comments

@Sleitnick
Copy link

It would be nice for the plugin to match Studio's theme. Currently the light theme sticks out quite a bit in Studio. I know this isn't a super high priority, but would be a "nice to have" feature in my opinion.

Screenshot example:

rojo_theme
@LPGhatguy LPGhatguy added scope: plugin Relevant to the Roblox Studio plugin type: enhancement Feature or improvement that should potentially happen labels Aug 30, 2019
@Jaguar-515
Copy link
Contributor

Jaguar-515 commented Aug 30, 2019 •
edited
Loading

We could implement that by adding an if/else statement that detects the user's theme on Studio, then the plugin uses the dark theme whenever a user is on dark mode, else, a user is on light mode, the plugin uses it's default theme.

I believe there's an Enum that detects whatever the user's Studio theme is?

@Jaguar-515 Jaguar-515 mentioned this issue Aug 30, 2019
Closed
Dekkonot pushed a commit to UpliftGames/rojo that referenced this issue Jan 11, 2024
@LPGhatguy
Dynamic theming. Closes rojo-rbx#241.
00de188 
Upgrades to Roact master and introduces dynamic theme switching.

We branch on the theme name in order to try to use Rojo's brand
colors instead of Studio's. I kind of winged it with these colors
and we might want to choose slightly nicer dark theme colors
in the future.

I also took the opportunity to reorganize the color naming scheme
since it didn't really work for dark theme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: plugin Relevant to the Roblox Studio plugin type: enhancement Feature or improvement that should potentially happen
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Theme for Dark Mode
3 participants
@LPGhatguy @Sleitnick @Jaguar-515