Make snapshot application communicative #135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is part of an ongoing effort to make Rojo deterministic, which makes it more robust as well as easier to test and debug.
Without this change, Rojo has nondeterministic child ordering once changes are applied to a running DOM, like in a live sync session. That means that restarting the Rojo server can result in a slightly different tree being presented, which has made snapshot testing a little bit sketchy.
The following things are deterministic with reordered change events either in master or with this change:
RbxTree
objects, now with patchesThe following things still need to be modified to be deterministic in the face of patches being reordered:
rbxmx
,rbxlx
,rbxm
andrbxl
filesTODO:
rbx_dom_weak
that allows reordering of children