Block usage of "Name" or "Parent" in $properties #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! I adjusted the code a little bit (using pattern matching instead of an array) and am merging it in! |
LPGhatguy
approved these changes
Apr 23, 2021
|
Cool! Was thinking about using a match at first but I don't quite know Rust best practices yet so I went with an array instead. |
Closed
Dekkonot
pushed a commit
to UpliftGames/rojo
that referenced
this pull request
Jan 11, 2024
* Ignore usage of "Name" or "Parent" in $properties * Use match instead of array * Add changelog entry Co-authored-by: Lucien Greathouse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #391.
This pull makes the usage of "Name"/"Parent" in $properties ignored, with a warning to the user that said properties cannot be set. Maybe exiting with an error would be better?