Support long file paths on Windows (past 256 limit) #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue can occur when using symlinks deep in rojo such that very long paths can occur, among other scenarios. Note while the original fix comes from here: https://gal.hagever.com/posts/windows-long-paths-in-rust/ The manifest had to be modified from this source: https://stackoverflow.com/questions/59816045/windows-10-1903-longpathaware-not-working
Quenty
force-pushed
the
users/quenty/long_file_paths
branch
from
77bcd31 to
15e7f36
Compare
|
Oh, whoops, thought we were moving stuff. Location is fine as-is. |
|
I did move stuff around, I was able to commit to your branch before merging :D |
|
Ohhh, lol, I force pushed probably wiping your changes, hahaha. Ok, this all makes sense. |
|
Nah, my changes are last, you can check the file changes tab to verify if you're curious. |
Dekkonot
pushed a commit
to UpliftGames/rojo
that referenced
this pull request
Jan 11, 2024
* Support long file paths on Windows (past 256 limit) This issue can occur when using symlinks deep in rojo such that very long paths can occur, among other scenarios. Note while the original fix comes from here: https://gal.hagever.com/posts/windows-long-paths-in-rust/ The manifest had to be modified from this source: https://stackoverflow.com/questions/59816045/windows-10-1903-longpathaware-not-working * Move manifests, tidy code a little Co-authored-by: Lucien Greathouse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue can occur when using symlinks deep in rojo such that very long paths can occur, among other scenarios.
Note while the original fix comes from here:
https://gal.hagever.com/posts/windows-long-paths-in-rust/
The manifest had to be modified from this source:
https://stackoverflow.com/questions/59816045/windows-10-1903-longpathaware-not-working