Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept .luau files #552

Merged
merged 11 commits into from
Jun 29, 2022
Merged

Accept .luau files #552

merged 11 commits into from
Jun 29, 2022

Conversation

imacodr
Copy link
Contributor

@imacodr imacodr commented Jun 12, 2022

This is really just a tracked PR to start accepting .luau files to the Rojo ecosystem as the language grows to separate itself a bit from Lua 5.

Solves #499

@LPGhatguy
Copy link
Contributor

Hello, thank you for the PR!

This PR looks like it adds support for the "Open Scripts in Studio" feature for .luau files only -- Rojo otherwise still will not recognize .luau files. I think we can put a fix together for that pretty easily, though!

@imacodr
Copy link
Contributor Author

imacodr commented Jun 12, 2022

I'm still figuring out a bit of the Rojo ecosystem for additional changes without breaking everything 😂

I'll be looking out for new changes to add to it for Luau support. Any other commits would be very helpful too.

Copy link
Contributor Author

@imacodr imacodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Serving unit tests are failing although I'm taking a closer look why. Tested in-studio and it seems to now sync as .luau

@LPGhatguy LPGhatguy merged commit acf7456 into rojo-rbx:master Jun 29, 2022
@imacodr imacodr deleted the luau-extension branch June 29, 2022 23:41
Dekkonot pushed a commit to UpliftGames/rojo that referenced this pull request Jan 11, 2024
* accept .luau files

* Accept .luau in snapshot creation

* Update versioning and snapshots.

* fix versioning

* Run rustfmt

* Reduce repetition in extension detection

* Tidy build script change

Co-authored-by: Lucien Greathouse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants