Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Notification sound to generic sound #566

Merged
merged 3 commits into from
Jul 2, 2022

Conversation

imacodr
Copy link
Contributor

@imacodr imacodr commented Jun 30, 2022

The notification sound for the plugin notifications causes the game to summon an error due to no experience permissions with no way to grant permission. This is due to the new audio policy update.

The notification sound causes the game to summon an error due to no experience permissions with no way to grant permission. This is due to the new audio policy update.
@boatbomber
Copy link
Member

I think the sound file in assets/ should be replaced as well to create consistency between our repo assets and the used assets.

@LPGhatguy
Copy link
Contributor

I don't know if this sound fits. What other notification sounds are available that will work?

@boatbomber
Copy link
Member

How about 203785492?

@LPGhatguy
Copy link
Contributor

How about 203785492?

Works for me!

@imacodr
Copy link
Contributor Author

imacodr commented Jul 2, 2022

Sounds good. Really annoying this restriction for plugins.

Copy link
Contributor

@LPGhatguy LPGhatguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@LPGhatguy LPGhatguy merged commit 535e4d4 into rojo-rbx:master Jul 2, 2022
@imacodr imacodr deleted the patch-1 branch July 2, 2022 23:34
Dekkonot pushed a commit to UpliftGames/rojo that referenced this pull request Jan 11, 2024
* Change Notification sound to generic sound

The notification sound causes the game to summon an error due to no experience permissions with no way to grant permission. This is due to the new audio policy update.

* Update Notification sound
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants