Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider drake's storage backend #931

Closed
3 tasks done
wlandau opened this issue Jul 5, 2019 · 3 comments
Closed
3 tasks done

Reconsider drake's storage backend #931

wlandau opened this issue Jul 5, 2019 · 3 comments

Comments

@wlandau
Copy link
Member

wlandau commented Jul 5, 2019

Prework

  • Read and abide by drake's code of conduct.
  • Search for duplicates among the existing issues, both open and closed.
  • Advanced users: verify that the bottleneck still persists in the current development version (i.e. remotes::install_github("ropensci/drake")) and mention the SHA-1 hash of the Git commit you install.

Description

For its entire existence, drake has relied on the storr package as a caching backend. storr has an amazing API and internal design, and I love its namespace functionality. However, given #907 and #930 (comment), drake's demands may have exceeded storr's performance. We may need to implement a custom caching system someday. I hope we do not need to do anything so drastic, but the time has come to at least consider the possibility.

@wlandau
Copy link
Member Author

wlandau commented Jul 5, 2019

To be worth the effort, the new cache would need to

  • Meet or exceed these memory benchmarks.
  • Achieve fst-like speeds for both small and large data.
  • Use storr's API so we can swap it out and maintain back compatibility.

@wlandau
Copy link
Member Author

wlandau commented Jul 28, 2019

Closing for now. drake's memory consumption far exceeds that of storr (re #932) and we should see speedups from richfitz/storr#111.

@wlandau
Copy link
Member Author

wlandau commented Aug 4, 2019

From the last paragraph in richfitz/storr#77 (comment), there is a better way to work around the current limitations than to rewrite storr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant