-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specialized formats for big targets #977
Conversation
Only return_fst() and return_keras() remain.
Also cc @schnorr and @guilhermealles. |
Codecov Report
@@ Coverage Diff @@
## master #977 +/- ##
======================================
Coverage 100% 100%
======================================
Files 45 46 +1
Lines 6900 6323 -577
======================================
- Hits 6900 6323 -577
Continue to review full report at Codecov.
|
Summary
This PR implements specialized data storage and retrieval. By working around
storr
, we decrease memory consumption, and we increase speed for data frames and Keras models. Formats "fst", "keras", and "rds" are currently supported, and it will be easy to add more.This is an alternative to richfitz/storr#111 for specialized scenarios, with greater efficiency in those scenarios (ref: #907 (comment)). cc @nettoyoussef, @richfitz, @MarcusKlik. @kendonB and @cimentadaj, you might also be interested.
How it works
Select the format in
target()
or by manually appending a "format" column to the plan.Created on 2019-08-05 by the reprex package (v0.3.0)
Implementation
drake
now uses a decoratedstorr
internally, which is just an ordinarystorr
wrapped up in a reference class.Related GitHub issues and pull requests
Checklist
drake
's code of conduct.testthat
unit tests totests/testthat
for any new functionality.